Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2138: parse tag in block #73

Closed
wants to merge 2 commits into from
Closed

fix 2138: parse tag in block #73

wants to merge 2 commits into from

Conversation

giuliolunati
Copy link

parse "test" [ copy content to [] (print content)]
BEFORE:

test<
AFTER:
test

parse "test<a>" [ copy content to [<a>] (print content)]
BEFORE:
>> test<
AFTER:
>> test
@hostilefork
Copy link
Member

Good to take this on, but you're repeating the copy-series thing which I was skeptical of in the place you copied from...

We should try to make the copy unnecessary in both cases and do so in a way that doesn't repeat code. Generally, I think PARSE needs to be hammered into shape more clearly as a whole!

Let's see if we can fix this in a way that doesn't need the copy...

@hostilefork
Copy link
Member

I guess we never got around to doing this efficiently... and this has been sitting here since last year!

Better to do it right and inefficiently as a note of what needs to be done than to just have a bug, so I merged it. Took me long enough. :-/

It would be helpful if you could go through all your branches and find anything still relevant, and delete anything that isn't. specific binding is a very big change, so if anything is outstanding I want to process it before that, not after...

Thanks!

@giuliolunati giuliolunati deleted the fix-2138-parse-tag-in-block branch November 18, 2016 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants